Can add back kwarg 'reset_socket' to disable closing sockets on error

[DionSun]

Can add kwarg 'reset_socket' to disable closing sockets on error

Versions

• Python: 3.8.10
• OS: windows 10
• Pymodbus: 3.6.8
• Modbus Hardware (if used):

Pymodbus Specific

• Client: tcp - sync

Description

kwarg 'reset_socket' is used in Pymodbus 2.5.3 . but removed on 3.5.1. I think this feature is useful on some situation. Can we add the reset_socket parameter back?

reference:

629 Add kwarg 'reset_socket' to disable closing sockets on error #631

Always close socket on error (reset_sock) #1767

[janiversen]

Pull requests are welcome, but be aware it will only be accepted for the sync version!

The async version works quite differently, and there it will be a lot more complicated not to close the socket.

[janiversen]

oooh we do not use kwargs anymore, it needs to be a real optional parameter.

[github-actions[bot]]

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

[github-actions[bot]]

This issue was closed because it has been stalled for 5 days with no activity.