target machine actively refused connection

amarco commented 1 month ago

I am wondering if there is a more forcefully way to disconnect and ensure no connections happen or is there some other problem afoot.

My getdata method is below...using 3.6.8 of library with python 3.11

def GetData(regStart,numOfReg, returnType):

client = ModbusTcpClient(host="redacted",port=502, framer=Framer.SOCKET, retries=3, timeout=30 )
time.sleep(1)
try:
    client.connect()

    if not client.connected:
        log.info(f"...Client error: {client.error_received()}")
        log.info("...Modbus TCP client could not connect; Exiting")
        sys.exit(1)

except SocketError as e:
    log.info(f"...Modbus exception: {e} ; Exiting")
    sys.exit(1)

try:
    regList = client.read_input_registers(address=regStart,count=numOfReg,slave=1)

    if not client.connected:
        log.info(f"...Client disconnected during read {client.error_received()}")
        sys.exit(1)

    if regList is None:
        log.info(f"...no register(s) returned; Exiting")
        sys.exit(1)

    client.close()

    match returnType.name:
         case ReturnType.INT.name:       
             return BinaryPayloadDecoder.fromRegisters(regList.registers, Endian.BIG, wordorder=Endian.BIG).decode_32bit_int()
         case ReturnType.FLOAT.name:                 
             return BinaryPayloadDecoder.fromRegisters(regList.registers, Endian.BIG, wordorder=Endian.BIG).decode_32bit_float()
         case ReturnType.STRING.name:        
             return codecs.decode(BinaryPayloadDecoder.fromRegisters(regList.registers, Endian.BIG, wordorder=Endian.BIG)._payload,'utf-8').rstrip('\x00')                 
         case ReturnType.BOOL.name:        
             return bool(BinaryPayloadDecoder.fromRegisters(regList.registers, Endian.BIG, wordorder=Endian.BIG).decode_32bit_int())     
         case _:
             log.info(f"...unable to decode data; Exiting")
             sys.exit(1)

except ModbusIOException as e:
    log.info(f"...Modbus exception: {e} ; Exiting")
    sys.exit(1)

janiversen commented 1 month ago

Please run it with the pymodbus debug call, so we can see what happens.

Your code looks ok, but it is very unusual to disconnect/connect with every call.

janiversen commented 1 month ago

Your reglist wrong, in case of an error reglist is not none, but contains error info, please see our documentation

amarco commented 1 month ago

Sorry artifact of previous version which used different library will fix when back in office. Will do that and also generate debug.

Get Outlook for Androidhttps://aka.ms/AAb9ysg

From: jan iversen @.> Sent: Tuesday, May 14, 2024 10:55:42 AM To: pymodbus-dev/pymodbus @.> Cc: Marco Accardo @.>; Author @.> Subject: Re: [pymodbus-dev/pymodbus] target machine actively refused connection (Issue #2196)

Your reglist wrong, in case of an error reglist is not none, but contains error info, please see our documentation

— Reply to this email directly, view it on GitHubhttps://github.com/pymodbus-dev/pymodbus/issues/2196#issuecomment-2110459607, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAP7VX76ONK2FTIGYWGMLOTZCIQW5AVCNFSM6AAAAABHWF2ZSWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJQGQ2TSNRQG4. You are receiving this because you authored the thread.Message ID: @.***>

RWDI - A Platinum Member of Canada's 50 Best Managed Companies This communication is intended for the sole use of the party to whom it was addressed and may contain information that is privileged and/or confidential. Any other distribution, copying or disclosure is strictly prohibited. If you received this email in error, please notify us immediately by replying to this email and delete the message without retaining any hard or electronic copies of same. Outgoing emails are scanned for viruses, but no warranty is made to their absence in this email or attachments. If you require any information supplied by RWDI in a different format to facilitate accessibility, contact the sender of the email, email @.*** or call +1.519.823.1311. Please be aware that when you contact us with a business query we may collect and use your details for future communications.

amarco commented 1 month ago

Interesting, when it passes the server it thinks it connected to is my local machine " Socket ('10.10.34.76', 48533)" and when it fails it is trying to talk to "Connection to (10.10.4.167, 502) failed" not sure what is happening here?

Marco

From: jan iversen @.> Sent: Tuesday, May 14, 2024 10:54 AM To: pymodbus-dev/pymodbus @.> Cc: Marco Accardo @.>; Author @.> Subject: Re: [pymodbus-dev/pymodbus] target machine actively refused connection (Issue #2196)

Please run it with the pymodbus debug call, so we can see what happens.

Your code looks ok, but it is very unusual to disconnect/connect with every call.

- Reply to this email directly, view it on GitHubhttps://github.com/pymodbus-dev/pymodbus/issues/2196#issuecomment-2110456623, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAP7VX5RJN26FVGC3S5BKY3ZCIQR7AVCNFSM6AAAAABHWF2ZSWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJQGQ2TMNRSGM. You are receiving this because you authored the thread.Message ID: @.**@.>>

RWDI - A Platinum Member of Canada's 50 Best Managed Companies This communication is intended for the sole use of the party to whom it was addressed and may contain information that is privileged and/or confidential. Any other distribution, copying or disclosure is strictly prohibited. If you received this email in error, please notify us immediately by replying to this email and delete the message without retaining any hard or electronic copies of same. Outgoing emails are scanned for viruses, but no warranty is made to their absence in this email or attachments. If you require any information supplied by RWDI in a different format to facilitate accessibility, contact the sender of the email, email @.*** or call +1.519.823.1311. Please be aware that when you contact us with a business query we may collect and use your details for future communications.

janiversen commented 1 month ago

Are you sure you read that correctly?

the server socket is 502, but the client socket can be any number.

janiversen commented 1 month ago

Apart from that, your device is refusing the connection, probably because you make too many connections/disconnect in a very short time (most devices do not like that)

You really should do

open connection
read all registers
close connection

to test it without changing your code you can add a larger delay between each connect call.

amarco commented 1 month ago

I had thought of that and in fact that's the way I was doing but using a different modbus python library. When I switched to pymodbus I did the open/close for every get data cycle. I reworked the code to do a single open, read all parameters for all loads and then close. I left debug on, and will let run. I also add a short sleep of 0.3 sec between each get_data. Will see share what happens.

Marco

From: jan iversen @.> Sent: Tuesday, May 14, 2024 2:22 PM To: pymodbus-dev/pymodbus @.> Cc: Marco Accardo @.>; Author @.> Subject: Re: [pymodbus-dev/pymodbus] target machine actively refused connection (Issue #2196)

Apart from that, your device is refusing the connection, probably because you make too many connections/disconnect in a very short time (most devices do not like that)

You really should do

open connection
read all registers
close connection

to test it without changing your code you can add a larger delay between each connect call.

- Reply to this email directly, view it on GitHubhttps://github.com/pymodbus-dev/pymodbus/issues/2196#issuecomment-2110847712, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAP7VX6LYBO4ZM3JOFKV4W3ZCJI5DAVCNFSM6AAAAABHWF2ZSWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJQHA2DONZRGI. You are receiving this because you authored the thread.Message ID: @.**@.>>

RWDI - A Platinum Member of Canada's 50 Best Managed Companies This communication is intended for the sole use of the party to whom it was addressed and may contain information that is privileged and/or confidential. Any other distribution, copying or disclosure is strictly prohibited. If you received this email in error, please notify us immediately by replying to this email and delete the message without retaining any hard or electronic copies of same. Outgoing emails are scanned for viruses, but no warranty is made to their absence in this email or attachments. If you require any information supplied by RWDI in a different format to facilitate accessibility, contact the sender of the email, email @.*** or call +1.519.823.1311. Please be aware that when you contact us with a business query we may collect and use your details for future communications.

janiversen commented 1 month ago

If you keep the connection open there are NO reason for a sleep between read calls.

amarco commented 1 month ago

Understood, I removed the sleep. So far I got 2 clean sets of data, now I have removed the sleep, lets see how that goes during the evening 😊

From: jan iversen @.> Sent: Tuesday, May 14, 2024 4:53 PM To: pymodbus-dev/pymodbus @.> Cc: Marco Accardo @.>; Author @.> Subject: Re: [pymodbus-dev/pymodbus] target machine actively refused connection (Issue #2196)

If you keep the connection open there are NO reason for a sleep between read calls.

— Reply to this email directly, view it on GitHubhttps://github.com/pymodbus-dev/pymodbus/issues/2196#issuecomment-2111120266, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAP7VXYXHYBDXMYZWWEDLETZCJ2S7AVCNFSM6AAAAABHWF2ZSWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJRGEZDAMRWGY. You are receiving this because you authored the thread.Message ID: @.**@.>>

RWDI - A Platinum Member of Canada's 50 Best Managed Companies This communication is intended for the sole use of the party to whom it was addressed and may contain information that is privileged and/or confidential. Any other distribution, copying or disclosure is strictly prohibited. If you received this email in error, please notify us immediately by replying to this email and delete the message without retaining any hard or electronic copies of same. Outgoing emails are scanned for viruses, but no warranty is made to their absence in this email or attachments. If you require any information supplied by RWDI in a different format to facilitate accessibility, contact the sender of the email, email @.*** or call +1.519.823.1311. Please be aware that when you contact us with a business query we may collect and use your details for future communications.

amarco commented 1 month ago

Well things went good till they did not and then it never recovered. Logs at time of failure, once it happens the only way to recover as far as I have found thus far is to reboot the modbus device I am polling. Any thoughts. I keep thinking it exhausting tcp/ip resources but open/closing connection should of helped. I am new to modbus and find all this perplexing that it would work for hours and then burp out... Any thoughts are appreciated..

From: jan iversen @.> Sent: Tuesday, May 14, 2024 4:53 PM To: pymodbus-dev/pymodbus @.> Cc: Marco Accardo @.>; Author @.> Subject: Re: [pymodbus-dev/pymodbus] target machine actively refused connection (Issue #2196)

If you keep the connection open there are NO reason for a sleep between read calls.

- Reply to this email directly, view it on GitHubhttps://github.com/pymodbus-dev/pymodbus/issues/2196#issuecomment-2111120266, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAP7VXYXHYBDXMYZWWEDLETZCJ2S7AVCNFSM6AAAAABHWF2ZSWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJRGEZDAMRWGY. You are receiving this because you authored the thread.Message ID: @.**@.>>

RWDI - A Platinum Member of Canada's 50 Best Managed Companies This communication is intended for the sole use of the party to whom it was addressed and may contain information that is privileged and/or confidential. Any other distribution, copying or disclosure is strictly prohibited. If you received this email in error, please notify us immediately by replying to this email and delete the message without retaining any hard or electronic copies of same. Outgoing emails are scanned for viruses, but no warranty is made to their absence in this email or attachments. If you require any information supplied by RWDI in a different format to facilitate accessibility, contact the sender of the email, email @.*** or call +1.519.823.1311. Please be aware that when you contact us with a business query we may collect and use your details for future communications.

janiversen commented 1 month ago

This does not seem to be a modbus problem, but a tcp/ip problem.

Communicating on an open socket, does NOT use extra tcp/ip resources, but every connect uses quite a lot, and some devices are very slow in releasing these resources when the socket is closed.

Typically resources are not released before after 30 seconds !!! so if you need to ensure you do not connect/disconnect within that interval. Some devices take even longer to release the resources used by the socket (macOS as an example takes up to 2 hours).

The normal way is to connect once, and then simply read/write....the retries parameter ensure the library automatically reconnects when necessary. The reason I suggested a middle way was because I understood you wanted to disconnect/connect.

My production system (connection to a solar inverter) have been "connected" for more than 2months, in which time the router have rebooted several timer, but reconnect happen within the library. I do use the async version, which is a bit more modern, but I use to use the sync version without ever bothering to connect (apart from the initial one, during setup).

amarco commented 1 month ago

I am tending to agree as no code pattern has been able to solve the problem. I have sent email to the maker of the meter I am using to see if perhaps a firmware upgrade exists or they can shed some insights into this. Thankyou for your comments.

From: jan iversen @.> Sent: Wednesday, May 15, 2024 10:11 AM To: pymodbus-dev/pymodbus @.> Cc: Marco Accardo @.>; Author @.> Subject: Re: [pymodbus-dev/pymodbus] target machine actively refused connection (Issue #2196)

This does not seem to be a modbus problem, but a tcp/ip problem.

Communicating on an open socket, does NOT use extra tcp/ip resources, but every connect uses quite a lot, and some devices are very slow in releasing these resources when the socket is closed.

Typically resources are not released before after 30 seconds !!! so if you need to ensure you do not connect/disconnect within that interval. Some devices take even longer to release the resources used by the socket (macOS as an example takes up to 2 hours).

The normal way is to connect once, and then simply read/write....the retries parameter ensure the library automatically reconnects when necessary. The reason I suggested a middle way was because I understood you wanted to disconnect/connect.

My production system (connection to a solar inverter) have been "connected" for more than 2months, in which time the router have rebooted several timer, but reconnect happen within the library. I do use the async version, which is a bit more modern, but I use to use the sync version without ever bothering to connect (apart from the initial one, during setup).

- Reply to this email directly, view it on GitHubhttps://github.com/pymodbus-dev/pymodbus/issues/2196#issuecomment-2112660035, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAP7VXZO2LMIAMETDWCTBL3ZCNUHZAVCNFSM6AAAAABHWF2ZSWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJSGY3DAMBTGU. You are receiving this because you authored the thread.Message ID: @.**@.>>

RWDI - A Platinum Member of Canada's 50 Best Managed Companies This communication is intended for the sole use of the party to whom it was addressed and may contain information that is privileged and/or confidential. Any other distribution, copying or disclosure is strictly prohibited. If you received this email in error, please notify us immediately by replying to this email and delete the message without retaining any hard or electronic copies of same. Outgoing emails are scanned for viruses, but no warranty is made to their absence in this email or attachments. If you require any information supplied by RWDI in a different format to facilitate accessibility, contact the sender of the email, email @.*** or call +1.519.823.1311. Please be aware that when you contact us with a business query we may collect and use your details for future communications.

janiversen commented 1 month ago

Closing as this is not a pymodbus bug.

pymodbus-dev / pymodbus

target machine actively refused connection #2196