search

pymtl / pymtl3

Pymtl 3 (Mamba), an open-source Python-based hardware generation, simulation, and verification framework
BSD 3-Clause "New" or "Revised" License
388 stars 46 forks source link

adding ascii mode for printwave_pass #142

Closed kaishuocheng closed 4 years ago

kaishuocheng commented 4 years ago

I add an option for ascii mode, although default mode is still text_fancy.

codecov[bot] commented 4 years ago

Codecov Report

Merging #142 into master will increase coverage by <.01%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #142      +/-   ##
==========================================
+ Coverage   90.32%   90.33%   +<.01%     
==========================================
  Files         278      278              
  Lines       23967    23965       -2     
==========================================
  Hits        21649    21649              
+ Misses       2318     2316       -2
Impacted Files Coverage Δ
pymtl3/passes/tracing/CollectSignalPass.py 96.29% <ø> (+3.19%) :arrow_up:
pymtl3/passes/tracing/test/PrintWavePass_test.py 100% <100%> (ø) :arrow_up:
pymtl3/passes/tracing/PrintWavePass.py 94.91% <100%> (+0.84%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6348505...994a24b. Read the comment docs.

cbatten commented 4 years ago

I think maybe the default should be ascii so things "just work" on repl.it?

kaishuocheng commented 4 years ago

I think maybe the default should be ascii so things "just work" on repl.it?

Yeap I can flip it. But there is a checker that forces the user to set the "._tracing" to be either "text_ascii" or "text_fancy". I think it is helpful so I leave it there, or maybe we want to remove that?