pymtl / pymtl3

Pymtl 3 (Mamba), an open-source Python-based hardware generation, simulation, and verification framework
BSD 3-Clause "New" or "Revised" License
388 stars 46 forks source link

Improve import pass #145

Closed jsn1993 closed 4 years ago

jsn1993 commented 4 years ago

I remove the connections and mangled_ports in sv import pass. As a by-product, I was actually able to drastically simplify yosys import pass. Now it overrides only the "mangling scheme" part of the general SV import pass .

codecov[bot] commented 4 years ago

Codecov Report

Merging #145 into master will increase coverage by 0.06%. The diff coverage is 94.37%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #145      +/-   ##
==========================================
+ Coverage   90.36%   90.42%   +0.06%     
==========================================
  Files         278      277       -1     
  Lines       24005    23745     -260     
==========================================
- Hits        21692    21472     -220     
+ Misses       2313     2273      -40
Impacted Files Coverage Δ
...ackends/sverilog/import_/test/SVNameMangle_test.py 100% <ø> (ø) :arrow_up:
...kends/sverilog/import_/test/ImportedObject_test.py 100% <ø> (ø) :arrow_up:
pymtl3/passes/backends/yosys/import_/ImportPass.py 97.91% <100%> (+25.35%) :arrow_up:
...ds/sverilog/import_/test/SVImportSignalGen_test.py 100% <100%> (ø) :arrow_up:
...mtl3/passes/tracing/test/VcdGenerationPass_test.py 97.87% <100%> (ø) :arrow_up:
...s/backends/sverilog/translation/TranslationPass.py 100% <100%> (ø) :arrow_up:
pymtl3/datatypes/bitstructs.py 97.72% <100%> (-0.21%) :arrow_down:
pymtl3/passes/backends/sverilog/util/utility.py 86.48% <100%> (ø) :arrow_up:
...sses/backends/yosys/translation/TranslationPass.py 100% <100%> (ø) :arrow_up:
...mtl3/passes/backends/sverilog/util/test_utility.py 80.16% <42.85%> (ø) :arrow_up:
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f1cb0cc...1fae7d6. Read the comment docs.