search

pymtl / pymtl3

Pymtl 3 (Mamba), an open-source Python-based hardware generation, simulation, and verification framework
BSD 3-Clause "New" or "Revised" License
388 stars 46 forks source link

Fix a placeholder caching issue #199

Closed ptpan closed 4 years ago

ptpan commented 4 years ago

Fixed an issue where the translation result of a placeholder component disables import caching.

ptpan commented 4 years ago

@jsn1993 I think a minor release including this PR and #198 would be nice.. what do you think?

codecov[bot] commented 4 years ago

Codecov Report

Merging #199 into master will increase coverage by 0.00%. The diff coverage is 91.66%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #199   +/-   ##
=======================================
  Coverage   90.48%   90.49%           
=======================================
  Files         316      316           
  Lines       27811    27832   +21     
=======================================
+ Hits        25166    25187   +21     
  Misses       2645     2645
Impacted Files Coverage Δ
...ends/verilog/import_/VerilogVerilatorImportPass.py 93.58% <50.00%> (-0.15%) :arrow_down:
...ends/verilog/translation/VerilogTranslationPass.py 73.17% <66.66%> (ø)
...s/verilog/import_/VerilogVerilatorImportConfigs.py 83.67% <100.00%> (+0.22%) :arrow_up:
pymtl3/passes/backends/verilog/util/utility.py 92.54% <100.00%> (+0.87%) :arrow_up:
pymtl3/dsl/Connectable.py 84.32% <0.00%> (+0.27%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e2574e9...0976c37. Read the comment docs.