search

pymtl / pymtl3

Pymtl 3 (Mamba), an open-source Python-based hardware generation, simulation, and verification framework
BSD 3-Clause "New" or "Revised" License
388 stars 46 forks source link

[stdlib] fix val/rdy autoconnect #223

Closed yo96 closed 10 months ago

yo96 commented 2 years ago

This PR includes the following changes:

codecov[bot] commented 2 years ago

Codecov Report

Merging #223 (c7acb92) into master (781ce84) will increase coverage by 0.14%. The diff coverage is 67.09%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #223      +/-   ##
==========================================
+ Coverage   89.26%   89.41%   +0.14%     
==========================================
  Files         330      330              
  Lines       30242    30316      +74     
==========================================
+ Hits        26996    27107     +111     
+ Misses       3246     3209      -37
Impacted Files Coverage Δ
pymtl3/stdlib/stream/ifcs.py 56.92% <45.65%> (-27.29%) :arrow_down:
pymtl3/stdlib/stream/test/ifcs_test.py 98.41% <98.41%> (ø)
.../translation/structural/VStructuralTranslatorL4.py 85.48% <0.00%> (+0.13%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 781ce84...c7acb92. Read the comment docs.

ptpan commented 11 months ago

@yo96 I'm a bit out of the loop -- do we still want this fix as part of the 4.0 release? If so I'll point the base of this PR to the 4.0 release staging branch and we can start from there.. otherwise we should consider closing this because it's been inactive for quite a while?

yo96 commented 11 months ago

Do we still want to keep the CL to RTL(val/rdy) auto-connection? If so then we may still need the fix.

ptpan commented 10 months ago

Closing this due to inactivity