search

pymtl / pymtl3

Pymtl 3 (Mamba), an open-source Python-based hardware generation, simulation, and verification framework
BSD 3-Clause "New" or "Revised" License
388 stars 46 forks source link

Fixing subscript error with array of ifcs #228

Closed ptpan closed 2 years ago

ptpan commented 2 years ago

The VTB generation pass does not correctly mangle the Python name of arrays of interfaces signals. This PR patches the VTB generation pass by checking if an rt.Array of ports belongs to an interface before expanding its Python name.

codecov[bot] commented 2 years ago

Codecov Report

Merging #228 (7134669) into master (8af8102) will decrease coverage by 0.38%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #228      +/-   ##
==========================================
- Coverage   89.13%   88.75%   -0.39%     
==========================================
  Files         330      330              
  Lines       30318    29286    -1032     
==========================================
- Hits        27025    25993    -1032     
  Misses       3293     3293
Impacted Files Coverage Δ
.../passes/backends/verilog/tbgen/VerilogTBGenPass.py 94.11% <100.00%> (-0.07%) :arrow_down:
pymtl3/dsl/AstHelper.py 62.67% <0.00%> (-28.71%) :arrow_down:
...asses/rtlir/behavioral/BehavioralRTLIRGenL1Pass.py 84.98% <0.00%> (-8.91%) :arrow_down:
...backends/yosys/import_/YosysVerilatorImportPass.py 39.02% <0.00%> (-4.16%) :arrow_down:
pymtl3/stdlib/stream/fl.py 16.29% <0.00%> (-2.18%) :arrow_down:
pymtl3/dsl/test/Slicing_test.py 89.21% <0.00%> (-1.50%) :arrow_down:
pymtl3/stdlib/queues/cl_queues.py 93.02% <0.00%> (-1.32%) :arrow_down:
pymtl3/stdlib/ifcs/get_give_ifcs.py 28.92% <0.00%> (-1.08%) :arrow_down:
pymtl3/dsl/test/DataStruct_test.py 92.25% <0.00%> (-1.06%) :arrow_down:
pymtl3/passes/testcases/test_cases.py 86.59% <0.00%> (-1.01%) :arrow_down:
... and 131 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8af8102...7134669. Read the comment docs.