pymtl / pymtl3

Pymtl 3 (Mamba), an open-source Python-based hardware generation, simulation, and verification framework
BSD 3-Clause "New" or "Revised" License
388 stars 46 forks source link

Renaming ports and signals to ensure a consistent naming convention #261

Closed ptpan closed 10 months ago

ptpan commented 11 months ago

This PR implements the following signal and port name changes to ensure a consistent naming convention:

With this PR, we will be using three-letter names across important ports/signals: clk, rst, val, rdy, req, rsp.

codecov[bot] commented 11 months ago

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (6da7397) 90.27% compared to head (72f1807) 89.82%.

:exclamation: Current head 72f1807 differs from pull request most recent head e6c2253. Consider uploading reports for the commit e6c2253 to get more accurate results

Files Patch % Lines
pymtl3/stdlib/mem/MemRequesterAdapterFL.py 0.00% 7 Missing :warning:
pymtl3/stdlib/xcel/XcelRequesterAdapterFL.py 0.00% 7 Missing :warning:
pymtl3/stdlib/reqresp/ifcs/ifcs.py 83.33% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## pp482-ece4750-2022-changes #261 +/- ## ============================================================== - Coverage 90.27% 89.82% -0.45% ============================================================== Files 317 317 Lines 29199 28222 -977 ============================================================== - Hits 26358 25350 -1008 - Misses 2841 2872 +31 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.