add expected type and some typings

pymupdf / RAG

RAG (Retrieval-Augmented Generation) Chatbot Examples Using PyMuPDF

https://pymupdf.readthedocs.io/en/latest/pymupdf4llm

GNU Affero General Public License v3.0

539 stars 82 forks source link

add expected type and some typings #16

Closed fareshan closed 5 months ago

fareshan commented 6 months ago

I am suggesting these changes:

add/fix some typings
handle some None values
add an expected_type parameter : this is breaking change, so maybe you suggest a different way of handling this

Why this last change ? to get the exact type when we use this library, and avoid adding #type: ignore every time, or if isinstance(str) ... Maybe you have a better suggestion to handle this ?

I noticed that I should also add typings to the pymupdf library too.

JorjMcKie commented 5 months ago

Thank you for your contribution - we do really appreciate it!

The package is rapidly becoming more and more popular and is therefore receiving many functional enhancement requests. Investigating these requests and incorporating respective features is currently our top priority. We also need to cover all maintained Python versions - which limits the range of typing support that can be implemented.

So I am afraid we need to postpone this PR to a later point in time.