Accept Path object in to_markdown function

[JorjMcKie]

Thank you for the contribution - much appreciated! Actually, this is already supported implicitly: I just have to change the check of the parameter type. The parameter is converted to a pymupdf.Document if not already one. And Document creation supports all imaginable alternatives - including pathlib Paths. So all I need to do is something like this:

if not isinstance(arg0, pymupdf.Document):
    doc=pymupdf.open(arg0)`
else:
    doc = arg0

[dantetemplar]

It seems to me that this approach will spoil the types a little. I think it's better to list all the suitable alternatives in the argument annotation. But in runtime itself, the if-else that you suggested fits well.

[dantetemplar]

In that case, should I implement it myself?

[JorjMcKie]

You can of course make that change immediately in you installation files.

[dantetemplar]

You can of course make that change immediately in you installation files.

I mean, I've added new commit with use of pymupdf.Document

[JorjMcKie]

As per the type checking mannerisms of these days: I think we will reduce that a little, because the repo is still in its early development stages. So that parameter and similar one will just be typing.Any things for the time being.

[dantetemplar]

As per the type checking mannerisms of these days: I think we will reduce that a little, because the repo is still in its early development stages. So that parameter and similar one will just be typing.Any things for the time being.

I understand you, but the pull request can still be accepted 🤗

[JorjMcKie]

Ok no problem actually - except, that we need your explicit agreement to our Contributor License Agreement. We are making sure that all user contributions are backed by a well-defined legal foundation. So please add a comment somewhere here with the wording like "I have read and herewith accept the Artifex Contributor License Agreement." That agreement can be downloaded / read from this site: https://artifex.com/contributor/

[dantetemplar]

Ok no problem actually - except, that we need your explicit agreement to our Contributor License Agreement. We are making sure that all user contributions are backed by a well-defined legal foundation. So please add a comment somewhere here with the wording like "I have read and herewith accept the Artifex Contributor License Agreement." That agreement can be downloaded / read from this site: https://artifex.com/contributor/

I hereby declare that I have read, understood, and accept the terms and conditions of the Artifex Contributor License Agreement.

[JorjMcKie]

Thank you - Done!