search

pymzml / pymzML

pymzML - an interface between Python and mzML Mass spectrometry Files
https://pymzml.readthedocs.io/en/latest/
MIT License
162 stars 92 forks source link

feature: handle in memory binary streams #118

Closed sylvainlb closed 5 years ago

MKoesters commented 5 years ago

Hi and thanks for contributing to pymzML!

I already had a look at your code and it looks fine. As soon as I have fixed the appveyor encoding issue and verified everything is running as expected, I'll merge your branch into master.

Best, Manuel

sylvainlb commented 5 years ago

Thanks a lot Manuel!

How often do you push updates on pypi?

MKoesters commented 5 years ago

Rather infrequently, unfortunately. However we're working on automating uploading new releases and I hope we can get this up and running as soon as possible. @JB-MS, can you upload this as soon as I have fixed the encoding Issue?

sylvainlb commented 5 years ago

Thanks!

Keep me posted.

Le mer. 13 mars 2019 à 12:59, Manuel notifications@github.com a écrit :

Rather infrequently, unfortunately. However we're working on automating uploading new releases and I hope we can get this up and running as soon as possible. @JB-MS https://github.com/JB-MS, can you upload this as soon as I have fixed the encoding Issue?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/pymzml/pymzML/pull/118#issuecomment-472393051, or mute the thread https://github.com/notifications/unsubscribe-auth/ABU_QwgaAZ-UZzik5Ln34LwDotkrQRGyks5vWOgHgaJpZM4brOow .

MKoesters commented 5 years ago

Hi @sylvainlb ,

I fixed your pull request and opened a new one. I'll merge this after talking to the rest of the team and make sure the new release gets uploaded to pypi. I'll give you notice here, as soon as the new package is uploaded

sylvainlb commented 5 years ago

Thanks!

Do you require some action from me?