search

pymzml / pymzML

pymzML - an interface between Python and mzML Mass spectrometry Files
https://pymzml.readthedocs.io/en/latest/
MIT License
162 stars 92 forks source link

Solution for obo file related errors #134

Closed ZhixuNi closed 5 years ago

ZhixuNi commented 5 years ago

Hi! As the developer of LipidHunter and LPPtiger, we appreciate your greate work on pymzML project.

Over the last few months, we keep receiving feed backs that there are obo file missing issues. This usually happens when the obo version in the mzML do not have corresponding obo file in the obo folder. However, some software generate mzML with built in obo version string like: '23:06:2017' which also mentioned in one other issue #71 reported.

Thus I made few changes to force the Reader to check obo version and file matches. It is now able to check obo version and try to fit the best obo version to the obo version in the mzML file.

Please have a look, thanks!

MKoesters commented 5 years ago

Hi ZhixuNi,

thanks for raising this Issue and coming up with a fix :) Indeed we were not very reliable on adding new obo files, sorry for that, I'll try to keep and eye on that in the future ;) I will review your Pull request now and test it with some mzMLs, especially with dates as obo version string.

Best, Manuel

fu commented 5 years ago

Thanks ZhixuNi!