search

pymzml / pymzML

pymzML - an interface between Python and mzML Mass spectrometry Files
https://pymzml.readthedocs.io/en/latest/
MIT License
162 stars 92 forks source link

Remove warning to install ms_deisotope #157

Closed michaelmarty closed 5 years ago

michaelmarty commented 5 years ago

I am using pymzml in another deconvolution python package. Can you remove the warning to install ms_deisotope when pymzml is imported? My users are probably going to be confused by the additional warning. I would suggest instead that it prints an error if ms_deisotope is not installed when you try to run it. Thanks!

MKoesters commented 5 years ago

Hi,

just created a pull request to print this warning only the first time _deconvolute_peaks() is used. Sry for the inconvenience, I'll merge the pull request this evening.

edit: I merged the fix into master, could you wait for some time for a new pypi release and pin your version to 2.3.1 or do you need a new release?

Best, Manuel

michaelmarty commented 5 years ago

Thanks, Manuel! I don't mind waiting for a new pypi release. I've fixed my local version. I think most users use the compiled version I build with PyInstaller, so fixing it locally should be fine for now. But, I appreciate not having to comment it out every time I update pymzml. Thanks, again! It's a fantastic package!