search

pymzml / pymzML

pymzML - an interface between Python and mzML Mass spectrometry Files
https://pymzml.readthedocs.io/en/latest/
MIT License
162 stars 92 forks source link

Feature/np optimization peaks #167

Closed MKoesters closed 4 years ago

MKoesters commented 4 years ago

Small optimization for combining mz and intensities. The old method is from the time were we supported both python lists and numpy arrays.

On my test file, this increased iteration of already centroided spectra by about 25%

codecov[bot] commented 4 years ago

Codecov Report

Merging #167 into dev will decrease coverage by 0.08%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #167      +/-   ##
==========================================
- Coverage   83.19%   83.11%   -0.09%     
==========================================
  Files          32       32              
  Lines        3505     3506       +1     
==========================================
- Hits         2916     2914       -2     
- Misses        589      592       +3
Impacted Files Coverage Δ
pymzml/spec.py 75.06% <100%> (-0.38%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c88f557...cbe5e72. Read the comment docs.

fu commented 4 years ago

Nice work ! simple is beautiful :)