search

pymzml / pymzML

pymzML - an interface between Python and mzML Mass spectrometry Files
https://pymzml.readthedocs.io/en/latest/
MIT License
158 stars 91 forks source link

add instrument, software, etc... #329

Closed wolfgangcolsman closed 10 months ago

sonarcloud[bot] commented 1 year ago

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 1 Security Hotspot
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

fu commented 1 year ago

Hi Wolfgang, we are looking at this, but we worry that storing the compelte xml element might not be aligned to the rest of the code. Stay tuned

wolfgangcolsman commented 1 year ago

I did this, because spectrum also has the element attached (if I remember correctly), so I thought it was aligned with your design. If you don't like it we will find a different solution.

fu commented 1 year ago

True, true! :) Now then let's black and all is good :)

fu commented 10 months ago

Created new PR #337 so I could fix black and tests. CI passing now.