Refactor spec spectrum - Githubissues

pymzml / pymzML

pymzML - an interface between Python and mzML Mass spectrometry Files

https://pymzml.readthedocs.io/en/latest/

MIT License

158 stars 91 forks source link

Refactor spec spectrum #334

Closed ap-- closed 9 months ago

ap-- commented 10 months ago

This PR addresses the issue described in #333.

provides a caching mechanism based on obo version for OboTranslator
allows Spectrum and Chromatogram to be instantiated with a obo_version as kwarg

Closes #333

fu commented 10 months ago

As starter - I think you need to black your code :) I will disable or fix the SonarCloud

ap-- commented 10 months ago

Done! 😃

The pre-commit config in the repo points to black==18.9b0 the tox "format" env with custom black config is commented out, and the CI uses black<23. Running black<23 with python3.8 locally, produces changes in other files too though.

To pass the CI checks, I pushed black fixes for the files I changed for now.

sonarcloud[bot] commented 9 months ago

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
2 Code Smells

No Coverage information
0.0% Duplication