search

pymzml / pymzML

pymzML - an interface between Python and mzML Mass spectrometry Files
https://pymzml.readthedocs.io/en/latest/
MIT License
158 stars 91 forks source link

Bug/none type #365

Closed wolfgangcolsman closed 1 month ago

wolfgangcolsman commented 1 month ago

Fix: AttributeError: 'NoneType' object has no attribute 'attrib'

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

wolfgangcolsman commented 1 month ago

Hi Christian, Manuel,

any chance you can push this fix to pypi? Thank you.

MKoesters commented 1 month ago

@fu should be good to merge, what do you think? We can either deploy during the next dev meeting or even before, if there is no need to discuss :)

wolfgangcolsman commented 1 month ago

Thank you!

Kind Regards,

Wolfgang Colsman

From: Manuel @.> Sent: Wednesday, May 8, 2024 2:43 PM To: pymzml/pymzML @.> Cc: Wolfgang Colsman @.>; Author @.> Subject: Re: [pymzml/pymzML] Bug/none type (PR #365)

@fuhttps://github.com/fu should be good to merge, what do you think? We can either deploy during the next dev meeting or even before, if there is no need to discuss :)

— Reply to this email directly, view it on GitHubhttps://github.com/pymzml/pymzML/pull/365#issuecomment-2101210183, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AMTCYPFLAPFPLDBFTPJFKQLZBJW6VAVCNFSM6AAAAABHKHOEGGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBRGIYTAMJYGM. You are receiving this because you authored the thread.Message ID: @.***>