pynbody / genetIC

The GM initial conditions generator
GNU General Public License v3.0
21 stars 8 forks source link

Quad modif #10

Closed Martin-Rey closed 7 years ago

apontzen commented 7 years ago

This branch is so far diverged from master that it's basically impossible to review. (The reviewing tools don't even seem to be working!) I propose we just merge it and deal with any problems that arise.

Martin-Rey commented 7 years ago

Alright. Let me take into account some of the comments you had earlier, make sure the test pass locally and then we can merge it.

Martin-Rey commented 7 years ago

That should do it. Hopefully there shouldn't be any conflict, most changes are localised in the modification namespace and involve the quadratic bit.

The test have been renamed and reorganised thematically. This is mostly renaming.

I have tried to be extra careful with removing machine dependent syntax but they might be some unwanted changes that slipped through in the CMAKE or Makefile files.

Let me know if you run into anything problematic or if you have problem merging.