search

pynbody / genetIC

The GM initial conditions generator
GNU General Public License v3.0
21 stars 8 forks source link

Flagging and grafic mapper #35

Closed Martin-Rey closed 6 years ago

Martin-Rey commented 6 years ago

When flagging cells from a file of IDs, the grafic mapper only flags and does not propagate them through the hierarchy of levels, contrary to usual SPH mappers.

The question is how should this be implemented to restore consistency, and allow for example to flag coarse cells from a purely zoomed output.

Since any cell at any level can be flagged from a file with grafic, there is a need to propagate cells "up" (from zoom to coarse) AND "down" (from coarse to zoom). Do you agree with this or do you think that only the "up" route is relevant for most applications ? Are there use cases where you would want to flag coarse cells but not the corresponding zoomed cells ?

apontzen commented 6 years ago

I think propagating upwards would be sufficient and propagating in both directions might get complicated, with possible ambiguities.

apontzen commented 6 years ago

I believe this issue is resolved and can be closed?