search

pynbody / genetIC

The GM initial conditions generator
GNU General Public License v3.0
21 stars 8 forks source link

Transfer functions #44

Closed svstopyra closed 5 years ago

svstopyra commented 6 years ago

This is the code for implementing the baryon transfer functions. It's still a work-in-progress as I'm still working on changes to ic.hpp to implement the switching behaviour there, and allow the user to actually access and use the new functionality.

apontzen commented 5 years ago

Thanks Stephen- can I just check if this addresses all comments and you think it's ready to merge? I'm happy to take your word on it and won't re-read the whole thing.

svstopyra commented 5 years ago

Hi Andrew,

I'm mostly sure it does - I went through everything one by one to make sure I corrected all the points you raised. The only thing that might not be quite finished is anything you didn't explicitly point out. For example, I'm sure there are probably a few comments I haven't yet updated to conform to the correct commenting convention yet - I changed most of them but there are probably a few that slipped through. Right now I'm working on the inline documentation though, so I'll probably catch those things as and when I come across them in the next couple of days.

In short - yes, I've addressed the points, so it should be ready to merge, but there may still be some tidying to do, and the inline documentation isn't yet finished.