pynbody / genetIC

The GM initial conditions generator
GNU General Public License v3.0
21 stars 8 forks source link

Issue 73: fixing missing overrides in dummy IC #77

Closed Martin-Rey closed 3 years ago

Martin-Rey commented 3 years ago

Hi all,

I believe this pull request adresses the unwelcome behaviour pointed out by #73. Sorry for the delay, this fix completely dropped under my radar.

The PR is nothing else than additional overrides in the DummyICGenerator class to ensure that any expensive operations (i.e. that trigger the random draw of the density field or attempt to create modification fields) are not performed.

I have identified reverse, apply_modifications, import_level, calculate, chi2 as such operations but let me know if there are other user-level functions that should be added.

I also added a test where all these functions are called in an input mapper parameter file, verifying that they are successfully skipped (since they don't produce any logged output)

Martin