New halo shape function fixes

pynbody / pynbody

N-body and hydro analysis tools for Python 3. (Older versions support Python 2.)

http://pynbody.github.io/pynbody/index.html

161 stars 76 forks source link

New halo shape function fixes #832

Closed apontzen closed 2 months ago

apontzen commented 2 months ago

Supplants #782

apontzen commented 2 months ago

pre-commit.ci autofix

apontzen commented 2 months ago

@morkney @bvogel4 this is my attempt to fix everything in #782 and make it mergeable - could you check it over please? Especially the new backward-compatibility wrapper.

Note: tests are failing due to ppa.launchpad.net being down

Bvogel4 commented 2 months ago

Thanks! @apontzen

I have reviewed the changes and tested them with my existing code.

The wrapper function performs exactly the same as before and provides the deprecation warning as expected.
I updated the stellar section of my code to call the new shape function, and I can confirm that it produced the same output as my custom function.

Edit: On Further investigation, it is not quite the exact same, as the convergence criteria has changed, but I think that is to be expected.