pynbody / tangos

The Agile Numerical Galaxy Organisation System
BSD 3-Clause "New" or "Revised" License
18 stars 13 forks source link

Mixed type data returns from property calculations #212

Open apontzen opened 1 year ago

apontzen commented 1 year ago

211 provides a direct patch for an issue where "Nones" were being ignored when used in inclusion criteria.

However, the fix itself masks the deeper issue. If you gather a property which is some places stored as an integer and other places as a float, some of the data returned will be missing. (That is the origin of the Nones, at least in @TobiBu's case)

That would be extremely complicated to fix without degrading performance, so I am posting it here as a separate issue, hopefully to be addressed one day.