search

pynbody / tangos

The Agile Numerical Galaxy Organisation System
BSD 3-Clause "New" or "Revised" License
18 stars 13 forks source link

rockstar+RAMSES functionality #238

Open AnatoleStorck opened 10 months ago

AnatoleStorck commented 10 months ago

Added functionality for adding RAMSES datasets with rockstar-galaxies catalogues using yt to tangos.

apontzen commented 10 months ago

Thanks @AnatoleStorck @cphyc - do you understand why the enzo test database now fails to build?

If needed you can try this locally by running export INTEGRATION_TESTING=1; ./build.sh in the test_tutorial_build folder

AnatoleStorck commented 10 months ago

I have moved the new functions in the general YT handler which were causing the Enzo test to fail (I still do not understand why) into the input handler for RAMSES+rockstar. The Enzo test now passes. Since this pull request is for supporting RAMSES+rockstar functionality, this should be fine.

apontzen commented 10 months ago

To me it looks like people who have developed their own input handlers that derive from YtInputHandler will be tripped up by this. Unfortunately I think it's necessary to solve the underlying problem rather than remove functionality from the crucial base class.

(I am not sure why the tests are not actually running on Github Actions, by the way - will see if I can figure that out)

AnatoleStorck commented 10 months ago

@cphyc and I fixed the issue, occurring due to the handler not importing the statfile if it exists.

apontzen commented 10 months ago

If you can pull master into this branch, it will also run the unit tests. At the moment only the integration test is running due to a configuration error in github actions.