Some small discrepancies known and not to be fixed:
black holes in changa+AHF may be assigned to a different halo. BH_central will be the same as it previously was, but BH now uses the AHF-provided parent relationship to assign to a top-level halo, rather than checking whether the BH itself is a member of a higher-level halo.
gadget+rockstar pynbody calculations look different but actually are far more sensible in v2. This appears to reflect a bug in the calculation of finder_offset, which was used for pynbody v1; now that tangos is passing through finder_ids instead, this has been fixed
Outstanding discrepancies still to be fixed:
[x] subfind-reported masses are coming out in Msol/h units rather than 1e10 Msol/h units as previously. This arises from allowing units to be attached to the quantity then stripping them out through a float(...) call. Since the philosophy is to import the raw values, this should be fixed, and it could be addressed at the same time as implementing a unified way to get property arrays from halos in pynbody.
[x] Gadget 4 tutorial is not importing at all, seemingly because pynbody v2 won't load the gadget4 subfind hdf5 files
Some small discrepancies known and not to be fixed:
BH_centralwill be the same as it previously was, butBHnow uses the AHF-provided parent relationship to assign to a top-level halo, rather than checking whether the BH itself is a member of a higher-level halo.finder_offset, which was used for pynbody v1; now that tangos is passing throughfinder_ids instead, this has been fixedOutstanding discrepancies still to be fixed:
float(...)call. Since the philosophy is to import the raw values, this should be fixed, and it could be addressed at the same time as implementing a unified way to get property arrays from halos in pynbody.