pyne / pyne

PyNE: The Nuclear Engineering Toolkit
http://pyne.io/
Other
261 stars 176 forks source link

Upstream branch PR: Install packages with Conda in Dockerfile #1509

Closed bquan0 closed 6 months ago

bquan0 commented 6 months ago

Description

See #1508 for more details on all the changes. This PR modifies ubuntu_22.04-dev.dockerfile to include separate stages apt_deps and conda-deps to allow for packages to be downloaded by either the package manager apt or conda. It also makes various changes in the workflows docker_publish.yml, build_test.yml, and virtualbox_image.yml to accomodate those changes.

Motivation and Context

This is the same PR as #1508, except that it's made from a branch on the pyne repo instead of my forked repo. This allows the workflows to build the images in the pyne ghcr.io, which will allow us to see if the build_test.yml will pass (since build_test.yml pulls images from the pyne ghcr.io to test).

Behavior

New behavior is that the build_test.yml workflow should run instead of erroring out because it couldn't find the proper image from ghcr.io.

Other Information

I noticed that in virtualbox_image.yml, we never make a VM from the hdf5 images. Is this something I should look into doing? Also, I was wondering if I should add some logic in build_test.yml to make it not run when the ${{ github.repository_owner }} isn't pyne because the workflow only uses images from the pyne ghcr.io.

Changelog file

All pull requests are required to update the CHANGELOG file with the PR. Your update can take different forms including:

bquan0 commented 6 months ago

You're right, I'll revert the changes to build_test.yml and apply them on a separate PR after this one is merged.