search

pyne / pyne

PyNE: The Nuclear Engineering Toolkit
http://pyne.io/
Other
261 stars 176 forks source link

Support Cython3+ #1525

Closed bennibbelink closed 2 months ago

bennibbelink commented 3 months ago

Description

This PR includes changes to support the use of Cython3+ in building PyNE.

Motivation and Context

It removes the pin of cython<3 in the Dockerfile, closes #1522

Changes

Dependency update

Behavior

Current behavior: PyNE build fails on the Cython compilation of enrichment.pyx, material_library.pyx, and cram.pyx when using Cython3+ New behavior: PyNE build succeeds using Cython3+

Other Information

This updates the MOAB version used in docker/ubuntu_22.04-dev.dockerfile to a 5.5.1, a version that supports Cython3+. Also, I created this branch from conda-build-fix

bennibbelink commented 3 months ago

I'm not familiar with CI in PyNE. Does it build/test with the develop branch instead of this PR?

I'll mark this as ready for review but someone with more PyNE CI expertise please chime in

ahnaf-tahmid-chowdhury commented 3 months ago

PR should be created for the development branch of PyNE. It seems you have created a PR on a different branch that is still working for the Conda fix. Please create a PR on the develop branch, or we can wait until PR #1516 gets merged?

bennibbelink commented 3 months ago

Changed base branch to develop, waiting on #1516

ahnaf-tahmid-chowdhury commented 2 months ago

Hi @bennibbelink, I regret to inform you that PR #1516 has been closed without merging. Could you please come up with fixing only the Cython3 support? This PR, for now, has many unwanted commits.

bennibbelink commented 2 months ago

@ahnaf-tahmid-chowdhury I've removed the unwanted commits, but (correct me if I'm wrong) without the changes from #1516 CI won't actually test against cython>=3

ahnaf-tahmid-chowdhury commented 2 months ago

I'm not sure if it's a good practice to come up with new commits here, especially since we've decided to decline the previous PR. It appears that the unwanted commits are still present. I hope @gonuke can provide better guidance on this.

In my case, I could either reset the current branch and bring it up to date with the develop branch. Alternatively, I could create another branch for a new PR, where I would merge only the commits I have created.

ahnaf-tahmid-chowdhury commented 2 months ago

The workflows are failing because, we need to set MOAB version to 5.5.1 as newer MOAB has only the cython3 support.

bennibbelink commented 2 months ago

I'll make a new branch. Stay tuned...

bennibbelink commented 2 months ago

Closing in favor of #1528.