search

pyne / pyne

PyNE: The Nuclear Engineering Toolkit
http://pyne.io/
Other
261 stars 176 forks source link

Fails to find moab-5.5.1 #1537

Closed yurivict closed 1 week ago

yurivict commented 3 weeks ago

Describe the Bug
Since moab was updated 5.3.1 → 5.5.1 PyNE-0.7.8 fails to find moab, and as a consequence fails to build pyne/source_sampling.so

Please complete the following information regarding your system:

Additional Context
FreeBSD port build.

gonuke commented 3 weeks ago

Thanks for sharing this. We recently worked on a number of updates for PyNE including newer MOAB as well as newer HDF5 and Cython (#1529) and will hopefully have a new release soon.

yurivict commented 3 weeks ago

Removing cmake/FindMOAB.cmake fixed the problem. MOAB provides its own cmake scripts, and you should use them instead of overriding them with a dysfunctional cmake/FindMOAB.cmake module, if this isn't yet done in #1529.

yurivict commented 3 weeks ago

@gonuke The latest develop branch revision 94655cf still fails to find moab.

You need to remove FindMOAB.cmake and use the MOAB-provided cmake scripts.

gonuke commented 3 weeks ago

I see! It looks like our tests appeared to be successful, but upon digging deeper, they are NOT. Thanks for alerting us to this. We'll also need to improve testing. #1526 is already aiming to solve this issue, and hopefully we can move that forward.

ahnaf-tahmid-chowdhury commented 3 weeks ago

Removing cmake/FindMOAB.cmake fixed the problem.

It seems interesting. I need to check if it also works on other platforms.

yurivict commented 3 weeks ago

It seems interesting. I need to check if it also works on other platforms.

configure finds MOAB when cmake/FindMOAB.cmake is removed, but then configure fails because some non-standard variables are used that were set by cmake/FindMOAB.cmake before.

ahnaf-tahmid-chowdhury commented 1 week ago

Fixed by #1526