search

pynetwork / pypcap

pypcap - python libpcap module, forked from code.google.com/p/pypcap
Other
299 stars 74 forks source link

Support create / activate paradigm for pcap objects, and RFMON #32

Closed ograff closed 6 years ago

ograff commented 8 years ago

Use pcap_create, then set options, and pcap_activate when creating pcap objects

Support setting rfmon option of pcap creation

Fixes #31

ograff commented 8 years ago

I totally forgot to test that before pushing, sorry ignore that commit

hellais commented 7 years ago

In general I think it's best if when submitting pull requests you don't also regenerate the c files as it makes diffs much more messy.

gpotter2 commented 6 years ago

Hello !

What is the status of this PR ?

We are calling pcap_set_rfmon in one of our implementation (secdev/scapy), so I would like to know if it will be available in next release, or if we should encourage users to skip pypcap

Thanks a lot for answering :) Regards,

hellais commented 6 years ago

Hi @gpotter2,

I left some comments on the PR, that should be addressed or dismissed. If you have some spare time, it would be great if you could help out with that.

Testing and code review of the PR is also appreciated. That will for sure speed up the time it takes to get this into a new release.

hellais commented 6 years ago

I just merged master into this branch in pynetwork/pypcap:rfmon_support

hellais commented 6 years ago

@ograff it seems like you didn't allow edits from the maintainer to this PR. Could you enable it? (see: https://help.github.com/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork/).

In the meantime I created a rebased PR of this in here: https://github.com/pynetwork/pypcap/pull/67

@gpotter2 could you help out with testing the branch and ensuring that this works as expected? If so I can, hopefully, within some reasonable amount of time work on putting out a new release with it.

ograff commented 6 years ago

Yes, I'll get that enabled later today, sorry about that!

On Feb 22, 2018 6:53 AM, "Arturo Filastò" notifications@github.com wrote:

@ograff https://github.com/ograff it seems like you didn't allow edits from the maintainer to this PR. Could you enable it? (see: https://help.github.com/articles/allowing-changes-to- a-pull-request-branch-created-from-a-fork/).

In the meantime I created a rebased PR of this in here: #67 https://github.com/pynetwork/pypcap/pull/67

@gpotter2 https://github.com/gpotter2 could you help out with testing the branch and ensuring that this works as expected? If so I can, hopefully, within some reasonable amount of time work on putting out a new release with it.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/pynetwork/pypcap/pull/32#issuecomment-367657771, or mute the thread https://github.com/notifications/unsubscribe-auth/AAOnrXTECS-RBvBayck2mWRi2CwajnQpks5tXVUzgaJpZM4JkCjY .

hellais commented 6 years ago

Closing this as it's been superseeded by the merged branch: https://github.com/pynetwork/pypcap/pull/67.