Release 1.2.0 - Githubissues

pynetwork / pypcap

pypcap - python libpcap module, forked from code.google.com/p/pypcap

Other

299 stars 74 forks source link

Release 1.2.0 #54

Closed hellais closed 6 years ago

hellais commented 7 years ago

I am going to use this branch to work towards releasing 1.2.0.

Checklist for release:

[x] Read diff with some extra care
[x] Smoke test it with some of my software that uses pypcap
[x] Do a bit of manual testing with python2 and python3
[x] Update changelog entry mentioning all the bugs that have been closed and added python 3 support
[x] Bump version number
[x] Tag a release
[ ] Upload to pypi

hellais commented 7 years ago

@nuald do you recall how you ran cython on the .pyx file. I don't seem to be able to get the exact same .c file as output. Any ideas how we can make this "reproducible"?

nuald commented 7 years ago

I guess you see this Cython issue: encodes absolute source path in output. Cython hadn't have releases for awhile and the fix is not in the stable version, so I'd recommend to install it from the sources (as it was mentioned in the documentation change I've submitted within Python 3 support code).

hellais commented 7 years ago

I guess you see this Cython issue: encodes absolute source path in output. Cython hadn't have releases for awhile and the fix is not in the stable version, so I'd recommend to install it from the sources (as it was mentioned in the documentation change I've submitted within Python 3 support code).

Yes that is one issue, but still even with the latest cython (0.26b0) I get a different .c file in output.

nuald commented 7 years ago

Yes, the C output differs, but I've verified - the newly generated C code is fine, all tests for both Py2 and Py3 are passed. You may want to regenerate C code and use it, or merge the changes from my branch (https://github.com/nuald/pypcap/tree/python3) - I've submitted the regenerated C code there.

wasilukm commented 7 years ago

Hi, what is a timeline of releasing 1.2.0?

hellais commented 6 years ago

Hi @wasilukm sorry I ended up being quite busy the past months. I will see if I can get something out this today.

hellais commented 6 years ago

So I made a release candiate that includes this branch: https://github.com/pynetwork/pypcap/releases/tag/v1.2.0-rc.1

I am going to give people a bit of time to test it and possibly report bugs and if nothing happens I will cut 1.2.0 and upload it to pypi.

Sound reasonable?

nuald commented 6 years ago

I guess so. However, installation instructions are out-dated (Npcap team pulled their project out from the Chocolatey). Do you want me to update it, and if yes, in what branch?

hellais commented 6 years ago

However, installation instructions are out-dated (Npcap team pulled their project out from the Chocolatey). Do you want me to update it, and if yes, in what branch?

yes please, that would be very useful.

I am not a Windows user so I am probably not the best to do that.

You should create a new PR with the documentation updates.