fix for Mac to get immediate mode in the case where BIOCIMMEDIATE isn't defined

pynetwork / pypcap

pypcap - python libpcap module, forked from code.google.com/p/pypcap

Other

299 stars 75 forks source link

fix for Mac to get immediate mode in the case where BIOCIMMEDIATE isn't defined #7

Closed brifordwylie closed 9 years ago

hellais commented 9 years ago

Excellent. Could you perhaps add a comment stating which version of OSX you have verified that BIOCIMMEDIATE does not exist?

It would then be ideal to rebase this branch into 1 commit and push it. Thanks! :8ball:

brifordwylie commented 9 years ago

Happy to add the comment about OSX version... rebase will be a continuous issue... hiding information/history/comments/discussions is completely the wrong thing to do IMO... https://guides.github.com/introduction/flow/ http://geekblog.oneandoneis2.org/index.php/2013/04/30/please-stay-away-from-rebase

hellais commented 9 years ago

Yes I also generally agree with the "don't rewrite history" approach, it was just that I thought it made sense to remove the commit about the tabs for a cleaner history.

I think this should only be done when it's on a non public working branch.