search

pynetwork / pypcap

pypcap - python libpcap module, forked from code.google.com/p/pypcap
Other
299 stars 75 forks source link

Regenerate C code (Fix setup issue on Python 3.7) #77

Closed lambdalisue closed 5 years ago

lambdalisue commented 6 years ago

To support building pypcap in Python 3.7, the latest cython was required.

Related issues https://github.com/numpy/numpy/issues/10500 https://github.com/cython/cython/issues/1955

hellais commented 6 years ago

@lambdalisue thanks for working on this.

To confirm is it the case that I can just update to the latest cython and push the rebuilt pcap.c? What is the required cython version?

We should probably codify this somewhere in the https://github.com/pynetwork/pypcap/blob/master/Makefile#L20 to ensure we are always using a version that will not break python 3.7 support.

lambdalisue commented 5 years ago

@hellais Sorry for the really late reply. I've forgotten about this PR.

To confirm is it the case that I can just update to the latest cython and push the rebuilt pcap.c? What is the required cython version?

Yes. And this time, it's 0.29.7, which is written in the header of pypcap.h

We should probably codify this somewhere in the https://github.com/pynetwork/pypcap/blob/master/Makefile#L20 to ensure we are always using a version that will not break python 3.7 support.

Instead, I added py37 to the tox.

lambdalisue commented 5 years ago

I'll remove the title - WIP once the Travis works correctly... 😢

lambdalisue commented 5 years ago

Finally :tada:

hellais commented 5 years ago

Sorry for getting back to you so late. This looks good to me. I am merging.

lambdalisue commented 5 years ago

So could you please upload the next version to PyPI?

hellais commented 5 years ago

So could you please upload the next version to PyPI?

Yes I am going to look into doing this today.

hellais commented 5 years ago

Tagged and uploaded a new release: https://pypi.org/project/pypcap/1.2.3/.

Let me know how it goes.