search

pynetwork / pypcap

pypcap - python libpcap module, forked from code.google.com/p/pypcap
Other
297 stars 74 forks source link

setup.py: support new CLT SDK #79

Closed DomT4 closed 5 years ago

DomT4 commented 5 years ago

As of macOS 10.14 installing the Command Line Tools will no longer create /usr/include, which is an intentional change by Apple. The headers are permanently moving inside the SDK, which is now provided by both Xcode and the CLT package.

Xcode is already supported here but people are considerably more likely to have the CLT installed due to it being a much more lightweight installation than the full Xcode IDE. This change ensures that once macOS Mojave/10.14 lands installation won't suddenly break, regardless of which of the CLT/Xcode choice people choose to go with.

Without this change the build bails out on:

Running command python setup.py egg_info
    pcap.h not found
Cleaning up...
hellais commented 5 years ago

LGTM. Thanks for putting this together!

DomT4 commented 5 years ago

Thanks for merging!