search

pyobs / pyobs-core

Core packages for pyobs
Other
10 stars 3 forks source link

Inconsistent offset output #329

Closed GermanHydrogen closed 6 months ago

GermanHydrogen commented 7 months ago

Offset is set as a string "offsets" in FitsHeaderOffsets https://github.com/pyobs/pyobs-core/blob/4478c3280307571db9e5110782c1ae61bfb95466/pyobs/images/processors/offsets/fitsheader.py#L40 Is this intentional or is the class depricated?

GermanHydrogen commented 7 months ago

This is apparently also the case in NStarOffsets https://github.com/pyobs/pyobs-core/blob/4478c3280307571db9e5110782c1ae61bfb95466/pyobs/images/processors/offsets/nstar.py#L89

thusser commented 7 months ago

Deprecated, should be changed to the new class-based offsets.

GermanHydrogen commented 6 months ago

Closed by PR #332