Telescope Test and Refactor

pyobs / pyobs-core

Core packages for pyobs

Other

10 stars 3 forks source link

Telescope Test and Refactor #345

Open GermanHydrogen opened 6 months ago

GermanHydrogen commented 6 months ago

TODO

[x] Unit test BaseTelescope
[ ] Refactor BaseTelescope
[x] Unit test DummyTelescope
[ ] Refactor DummyTelescope

GermanHydrogen commented 6 months ago

@thusser Do you know, why we are updating the "celestial" header every 30sec? https://github.com/pyobs/pyobs-core/blob/d5f79525842a7ff8cad0e650dd10b867385865de/pyobs/modules/telescope/basetelescope.py#L261

I do not see any reason, why this can't be calculated, when get_fits_header_before is called. Even if it would be computationally expensive, caching the result for 30sec seems like the better approach.