search

pyocd / cmsis-pack-manager

A Rust and Python module for handling CMSIS Pack files
Apache License 2.0
25 stars 33 forks source link

Purge slog for more ergonomic usage #136

Closed Yatekii closed 4 years ago

Yatekii commented 4 years ago

I removed slog from the crate to make usage more ergonomic and similar to what other crates do mostly.

There is no real replacement for the kv-replacement feature of slog. I tried my best to keep the information logged as before, but surely it wount be 100% the same.

Also, I used simplelog, which should generate nice, colored terminal output.

If anything is unsound, please point me to it, I'll hapily fix it.

theotherjimmy commented 4 years ago

There is no real replacement for the kv-replacement feature of slog. I tried my best to keep the information logged as before, but surely it wount be 100% the same.

That's great! I'm not worried about this log output changing from release to release, so long as users get something that we can handle in issues.

Yatekii commented 4 years ago

Yep, the CI fails for the same reason the previous PR does. I am gonna try and fix this. I already tried but I have no clue yet :/

theotherjimmy commented 4 years ago

I appreciate your efforts. You can find the CI scripts in this repo if that helps.

mathias-arm commented 4 years ago

This was folded into #143