search

pyocd / pyocd-pemicro

PEMicro probe plugin for pyOCD
Other
3 stars 1 forks source link

Fix the exception matching for version 0.1.6 #3

Closed anthrax-0 closed 3 years ago

anthrax-0 commented 3 years ago

Change the way the exception message is read to align with pypemicro version 0.1.6. Add PyOCD dependency as import requires it. Small formatting changes to comply with PEP8 :-)

And a small question: L303 and L316 has the self.APADDR referenced which is not resolving, where is it coming from?

flit commented 3 years ago

Strange, this PR didn't show up in my GH notifications.

flit commented 3 years ago

I merged your changes in manually. Thanks!

Good catch regarding self.APADDR. It looks to me like that symbol is just not defined, but flake8 doesn't report it as undefined. Really weird! I will go ahead and add a definition to PEMicroProbe just to be safe.