search

pyodide / matplotlib-pyodide

HTML5 backends for Matplotlib compatible with Pyodide
Mozilla Public License 2.0
33 stars 9 forks source link

Replace maxdict with lru_cache #52

Closed hoodmane closed 3 weeks ago

hoodmane commented 9 months ago

Matplotlib removed maxdict: https://matplotlib.org/stable/api/prev_api_changes/api_changes_3.6.0.html#miscellaneous-internals

I asked about this on the matplotlib discourse: https://discourse.matplotlib.org/t/matplotlib-pyodide-font-caching-with-maxdict-and-lru-cache/24260

codecov-commenter commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

:exclamation: No coverage uploaded for pull request base (main@61935f7). Click here to learn what that means.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #52 +/- ## ====================================== Coverage ? 0.00% ====================================== Files ? 4 Lines ? 648 Branches ? 0 ====================================== Hits ? 0 Misses ? 648 Partials ? 0 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

juntyr commented 3 weeks ago

What's the status of this PR?

hoodmane commented 3 weeks ago

I don't really understand matplotlib, so it's difficult to judge whether the patch is correct or not and I don't have that much faith in our test coverage. But it seems okay so we could just merge it and see if it unblocks the update. It would be nice to upstream some of the stuff but we have nobody who either understands matplotlib or wants to spend time learning about it. So it might be best just to wait until someone shows up with the inclination to maintain this.

ryanking13 commented 3 weeks ago

I think we can merge and release? @hoodmane