search

pyodide / micropip

A lightweight Python package installer for Pyodide
https://micropip.pyodide.org
Mozilla Public License 2.0
76 stars 21 forks source link

MAINT Split _micropip.py and tests into seperate files #56

Closed ryanking13 closed 1 year ago

ryanking13 commented 1 year ago

This splits a giant _micropip.py and tests into separate files.

A minor concern is that this would make it harder to port micropip tests to Pyodide repository. Probably we can make a list of core tests in a single file so we can copy it to Pyodide repository.

hoodmane commented 1 year ago

Yeah I'd like to do another review. Sorry for being slow on all these, I've been very busy the last few weeks. I'm flying home today so I'll hopefully have time to catch up on things in the next few days -- I'll be back in PST so fewer people will talk to me during my working hours...

rth commented 1 year ago

No worries, have a good flight!

ryanking13 commented 1 year ago

Thanks for the reviews!