pyodide / pyodide-actions

Github Actions for Pyodide
Mozilla Public License 2.0
7 stars 6 forks source link

A `setup-xbuildenv` composite action? #12

Open agriyakhetarpal opened 2 months ago

agriyakhetarpal commented 2 months ago

When writing a CI workflow for an out-of-tree build, one needs to:

We could implement a simple composite action that just wraps all of these steps with provided inputs.

Adding such an action and adopting it across a few packages' CI configurations gives us the added benefit that Dependabot will update the version when we release a new one here. It would also be beneficial because we would handle the versions ourselves, instead of packages having to manage the requisite versions themselves, for example:

https://github.com/scikit-image/scikit-image/blob/49e7af246f65a5030ae94b4c9304bc67cb8ccbc6/.github/workflows/emscripten.yml#L23-L31 (and others).

While this use case has already been covered by cibuildwheel with Pyodide support since version 2.19, it is currently not possible to modify the Pyodide version there in a clean manner since it is hard-coded and coupled with the cibuildwheel version (though, that may change).

ryanking13 commented 2 months ago

Sounds good to me. I would name it setup-pyodide-build.

agriyakhetarpal commented 2 months ago

Agreed, that sounds better!