search

pyodide / pyodide-build

Tool for building packages targeting Pyodide
Mozilla Public License 2.0
5 stars 5 forks source link

Infer python version from Makefile.envs in PyO3 #19

Closed ryanking13 closed 3 weeks ago

ryanking13 commented 1 month ago

Instead of hardcoding the Python version, use PYO3_CROSS_PYTHON_VERSION env variable, which PyO3 uses to find the correct Python include/lib paths.

Also removed pyo3_config.ini file. Otherwise, the config file always take precedence.

ryanking13 commented 3 weeks ago

It isn't working, but at least I found that integration tests are useful enough to detect this kind or errors :) Let's see if I can fix it.

ryanking13 commented 3 weeks ago

It is working now. I also checked it in pyodide/pyodide in my fork https://github.com/ryanking13/pyodide/commit/be7e588f6cf33fe7496e09b543b4a89753a469ef

ryanking13 commented 3 weeks ago

Thanks for the review!