search

pyodide / pyodide-build

Tool for building packages targeting Pyodide
Mozilla Public License 2.0
5 stars 5 forks source link

Add a `--keep-going` option to the `pyodide build` CLI #20

Open agriyakhetarpal opened 3 weeks ago

agriyakhetarpal commented 3 weeks ago

Description

This issue proposes the addition of a --keep-going option to enable building recipes until completion and listing failed recipes at the end of the build procedure – this is so that the procedure doesn't come to a halt once one recipe fails to build.

Motivation

This came about in pyodide/pyodide#4925 when updating quite a few recipes at once

agriyakhetarpal commented 3 weeks ago

I should be able to take a look at this myself in a while – and also come back to my other open PR :)

hoodmane commented 3 weeks ago

I made an attempt at this a while back. See also https://github.com/pyodide/pyodide/issues/3249 https://github.com/pyodide/pyodide/pull/4491

ryanking13 commented 3 weeks ago

Yes, it would be useful to have such flag. It won't be useful for non-maintainers so I am +1 for adding it as an hidden flag.

hoodmane commented 3 weeks ago

Personally I would prefer not to hide it. I think maintainers are the heaviest users of the CLI and it is annoying to have to grep the codebase. Others can either use it or not. The description will be simple enough.

ryanking13 commented 3 weeks ago

Sure, that's fine with me.