search

pyodide / pyodide-build

Tool for building packages targeting Pyodide
Mozilla Public License 2.0
5 stars 5 forks source link

Allow overriding _f2c_fixes.py from user #8

Closed ryanking13 closed 2 months ago

ryanking13 commented 2 months ago

While most parts of pyodide-build are decoupled with pyodide/pyodide, _f2c_fixes.py file that is used to build scipy is highly coupled with the scipy recipe in pyodide/pyodide.

It would be very inefficient if we need to update pyodide-build whenever we fix scipy (e.g. https://github.com/pyodide/pyodide/issues/4818). Therefore, this add a private config variable _f2c_fixes_wrapper, which allows users to modify override _f2c_fixes.py file without touching pyodide-build itself.

hoodmane commented 2 months ago

Interesting, thanks @ryanking13. Looks reasonable for now. I'm currently working on making a fork of f2c with modifications that suit our needs so hopefully we can get rid of f2c_fixes.

ryanking13 commented 2 months ago

I'm currently working on making a fork of f2c with modifications that suit our needs so hopefully we can get rid of f2c_fixes.

Cool. That sounds ambitious :)

Looks reasonable for now

Yeah, for now, I am trying to remove all annoying parts when unvendoring pyodide-build.