pyomeca / bioptim

An optimization framework that links CasADi, Ipopt, ACADOS and biorbd for Optimal Control Problem
MIT License
95 stars 47 forks source link

[RTM when answered] Solution integration for control_type.NONE problems #799

Closed Kev1CO closed 10 months ago

Kev1CO commented 1 year ago

All Submissions:

New Feature Submissions:

  1. [ ] Does your submission pass the tests (if not please explain why this is intended)?
  2. [ ] Did you write a proper documentation (docstrings and ReadMe)
  3. [ ] Have you linted your code locally prior to submission (using the command: black . -l120 --exclude "external/*")?

Changes to Core Features:


This change is Reviewable

Kev1CO commented 1 year ago

Also includes result.merge_phases() for control_type.NONE

Kev1CO commented 1 year ago

bioptim/interfaces/solve_ivp_interface.py line 369 at r1 (raw file):

Previously, pariterre (Pariterre) wrote…
Remove this

only len(x0.shape) < 2 was necessary, all offline tests went through

pariterre commented 1 year ago

Any ideas for the failing tests?

Kev1CO commented 1 year ago

bioptim/optimization/solution/solution.py line 1018 at r4 (raw file):

Previously, pariterre (Pariterre) wrote…
Discussed verbally...

Increases to much the computation time by removing skip data. Invert self with out instead. If tests goes through, ready to merge

Kev1CO commented 1 year ago

Don't know, seems that for other pr the tests fails aswell. In local, tests goes through.

pariterre commented 10 months ago

Closed as the major refactor makes this impossible to merge