[RTR] Parameters uniformisation

EveCharbie commented 9 months ago

All Submissions:

[x] Have you followed the guidelines in our Contributing document [docs/contribution.md]?
[x] Have you checked to ensure there aren't other open [Pull Requests] for the same update/change?
[x] Have you opened/linked the issue related to your pull request? issue #686
[x] Have you used the tag [WIP] for on-going changes, and removed it when the pull request was ready?
[x] When ready to merge, have you sent a comment pinging @pariterre in it?

New Feature Submissions:

[ ] Does your submission pass the tests (if not please explain why this is intended)?
[ ] Did you write a proper documentation (docstrings and ReadMe)
[ ] Have you linted your code locally prior to submission (using the command: black . -l120 --exclude "external/*")?

Changes to Core Features:

[ ] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new examples for your core changes, as applicable?
[ ] Have you written new tests for your core changes, as applicable?

This change is

EveCharbie commented 9 months ago

@pariterre I am not ready for a full review, but we would need to make a decision regarding parameters.mx_reduced (line 1082 in configure_problem for example).

EveCharbie commented 9 months ago

@pariterre I would need help for the remaining tests :)

EveCharbie commented 9 months ago

@pariterre our fix for Acados did not work. Can I leave it to you to fix it?

pariterre commented 9 months ago

@EveCharbie Yes, I am on my linux laptop today

codecov[bot] commented 9 months ago

Codecov Report

Attention: 39 lines in your changes are missing coverage. Please review.

Comparison is base (e54be49) 78.32% compared to head (7b772fa) 78.25%. Report is 6 commits behind head on master.

Files	Patch %	Lines
bioptim/optimization/parameters.py	81.66%	22 Missing :warning:
...optimization/stochastic_optimal_control_program.py	16.66%	5 Missing :warning:
bioptim/dynamics/dynamics_functions.py	63.63%	4 Missing :warning:
bioptim/optimization/variable_scaling.py	25.00%	3 Missing :warning:
bioptim/limits/objective_functions.py	77.77%	2 Missing :warning:
bioptim/interfaces/acados_interface.py	95.45%	1 Missing :warning:
bioptim/interfaces/interface_utils.py	87.50%	1 Missing :warning:
bioptim/optimization/non_linear_program.py	66.66%	1 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #846 +/- ## ========================================== - Coverage 78.32% 78.25% -0.07% ========================================== Files 140 139 -1 Lines 16232 16232 ========================================== - Hits 12714 12703 -11 - Misses 3518 3529 +11 ``` | [Flag](https://app.codecov.io/gh/pyomeca/bioptim/pull/846/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pyomeca) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/pyomeca/bioptim/pull/846/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pyomeca) | `78.25% <85.00%> (-0.07%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pyomeca#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

pyomeca / bioptim