pyomeca / bioptim

An optimization framework that links CasADi, Ipopt, ACADOS and biorbd for Optimal Control Problem
MIT License
94 stars 47 forks source link

[DO NOT MERGE] Stochastic plots, noisy_integrate, and other plot shits #853

Closed EveCharbie closed 7 months ago

EveCharbie commented 9 months ago

All Submissions:

New Feature Submissions:

  1. [ ] Does your submission pass the tests (if not please explain why this is intended)?
  2. [ ] Did you write a proper documentation (docstrings and ReadMe)
  3. [ ] Have you linted your code locally prior to submission (using the command: black . -l120 --exclude "external/*")?

Changes to Core Features:


This change is Reviewable

EveCharbie commented 9 months ago

@pariterre I need help handling matplotlib in a multiprocess, it seems like it is blocking somewhere. ChatGPT says it is because I try to update the plots outside of the main thread, but we do it for the regular live plots, so you know how to do it.

pariterre commented 9 months ago

@EveCharbie Yep! We can discuss this today!

codecov[bot] commented 8 months ago

Codecov Report

Attention: Patch coverage is 57.43243% with 189 lines in your changes are missing coverage. Please review.

Project coverage is 77.93%. Comparing base (ceb75c4) to head (ff8c300). Report is 1 commits behind head on master.

Files Patch % Lines
bioptim/gui/ipopt_output_plot.py 0.00% 68 Missing :warning:
bioptim/optimization/solution/solution.py 17.91% 55 Missing :warning:
bioptim/gui/plot.py 58.06% 13 Missing :warning:
bioptim/gui/online_callback.py 0.00% 11 Missing :warning:
bioptim/dynamics/configure_problem.py 66.66% 7 Missing :warning:
bioptim/gui/check_conditioning.py 95.90% 5 Missing :warning:
bioptim/limits/multinode_constraint.py 44.44% 5 Missing :warning:
...optimization/stochastic_optimal_control_program.py 16.66% 5 Missing :warning:
bioptim/dynamics/configure_new_variable.py 0.00% 3 Missing :warning:
bioptim/dynamics/ode_solver.py 62.50% 3 Missing :warning:
... and 7 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #853 +/- ## ========================================== - Coverage 78.50% 77.93% -0.58% ========================================== Files 141 142 +1 Lines 16309 16318 +9 ========================================== - Hits 12804 12718 -86 - Misses 3505 3600 +95 ``` | [Flag](https://app.codecov.io/gh/pyomeca/bioptim/pull/853/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pyomeca) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/pyomeca/bioptim/pull/853/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pyomeca) | `77.93% <57.43%> (-0.58%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pyomeca#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

EveCharbie commented 8 months ago

@pariterre I think we are good to merge if all the tests pass :)

EveCharbie commented 8 months ago

@pariterre shard 1 is really slow to run on Ubuntu.

EveCharbie commented 8 months ago

@pariterre it's good now :)

pariterre commented 7 months ago

Closed as merged in #867