pyomeca / bioptim

An optimization framework that links CasADi, Ipopt, ACADOS and biorbd for Optimal Control Problem
MIT License
94 stars 47 forks source link

[RTM when tests pass] Extra checks in holonomic model #854

Closed Ipuch closed 9 months ago

Ipuch commented 9 months ago

All Submissions:

New Feature Submissions:

  1. [ ] Does your submission pass the tests (if not please explain why this is intended)?
  2. [ ] Did you write a proper documentation (docstrings and ReadMe)
  3. [ ] Have you linted your code locally prior to submission (using the command: black . -l120 --exclude "external/*")?

Changes to Core Features:


This change is Reviewable

codecov[bot] commented 9 months ago

Codecov Report

Attention: Patch coverage is 95.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 78.26%. Comparing base (7494252) to head (64d8720). Report is 48 commits behind head on master.

Files Patch % Lines
bioptim/models/biorbd/holonomic_biorbd_model.py 95.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #854 +/- ## ======================================= Coverage 78.25% 78.26% ======================================= Files 139 139 Lines 16228 16244 +16 ======================================= + Hits 12699 12713 +14 - Misses 3529 3531 +2 ``` | [Flag](https://app.codecov.io/gh/pyomeca/bioptim/pull/854/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pyomeca) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/pyomeca/bioptim/pull/854/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pyomeca) | `78.26% <95.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pyomeca#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.