pyomeca / bioptim

An optimization framework that links CasADi, Ipopt, ACADOS and biorbd for Optimal Control Problem
MIT License
91 stars 46 forks source link

[RTM] external forces as symbolic variables to allow multi-threading #865

Closed EveCharbie closed 5 months ago

EveCharbie commented 5 months ago

All Submissions:

New Feature Submissions:

  1. [ ] Does your submission pass the tests (if not please explain why this is intended)?
  2. [ ] Did you write a proper documentation (docstrings and ReadMe)
  3. [ ] Have you linted your code locally prior to submission (using the command: black . -l120 --exclude "external/*")?

Changes to Core Features:


This change is Reviewable

codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 94.44444% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 78.51%. Comparing base (4cda59c) to head (4cc49ef). Report is 55 commits behind head on master.

Files Patch % Lines
bioptim/dynamics/configure_problem.py 75.00% 2 Missing :warning:
bioptim/models/biorbd/biorbd_model.py 95.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #865 +/- ## ======================================= Coverage 78.50% 78.51% ======================================= Files 141 141 Lines 16309 16296 -13 ======================================= - Hits 12804 12794 -10 + Misses 3505 3502 -3 ``` | [Flag](https://app.codecov.io/gh/pyomeca/bioptim/pull/865/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pyomeca) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/pyomeca/bioptim/pull/865/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pyomeca) | `78.51% <94.44%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pyomeca#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

EveCharbie commented 5 months ago

@pariterre can be merged