search

pyomeca / bioptim

An optimization framework that links CasADi, Ipopt, ACADOS and biorbd for Optimal Control Problem
MIT License
92 stars 46 forks source link

Needed to merge the two PRs here #867

Closed EveCharbie closed 7 months ago

EveCharbie commented 7 months ago

This change is Reviewable

EveCharbie commented 7 months ago

The only problem is RigidBodyDynamics.DAE_INVERSE_DYNAMICS for test_maximize_predicted_height_CoM_rigidbody_dynamics. @pariterre or @Ipuch could you tell me if this is a normal behavior (knowing that the max_iter is set to 1)?

pariterre commented 7 months ago

@EveCharbie I have never seen this particular test fail before. Therefore, I do not expect this test to be a sensitive test

codecov[bot] commented 7 months ago

Codecov Report

Attention: Patch coverage is 70.72848% with 221 lines in your changes are missing coverage. Please review.

Project coverage is 78.04%. Comparing base (4cc49ef) to head (93be904). Report is 1 commits behind head on master.

Files Patch % Lines
bioptim/gui/ipopt_output_plot.py 0.00% 68 Missing :warning:
bioptim/optimization/solution/solution.py 37.86% 64 Missing :warning:
bioptim/gui/plot.py 68.18% 14 Missing :warning:
bioptim/gui/online_callback.py 0.00% 11 Missing :warning:
bioptim/dynamics/configure_problem.py 82.75% 10 Missing :warning:
bioptim/models/biorbd/biorbd_model.py 83.33% 7 Missing :warning:
...optimization/stochastic_optimal_control_program.py 50.00% 7 Missing :warning:
bioptim/gui/check_conditioning.py 95.90% 5 Missing :warning:
bioptim/limits/multinode_constraint.py 44.44% 5 Missing :warning:
bioptim/dynamics/ode_solver.py 73.33% 4 Missing :warning:
... and 13 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #867 +/- ## ========================================== - Coverage 78.51% 78.04% -0.47% ========================================== Files 141 142 +1 Lines 16296 16464 +168 ========================================== + Hits 12794 12849 +55 - Misses 3502 3615 +113 ``` | [Flag](https://app.codecov.io/gh/pyomeca/bioptim/pull/867/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pyomeca) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/pyomeca/bioptim/pull/867/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pyomeca) | `78.04% <70.72%> (-0.47%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pyomeca#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

EveCharbie commented 7 months ago

@pariterre ready to merge :)