pyomeca / bioviz

Biorbd visualization toolkit
MIT License
18 stars 26 forks source link

Added the distance between markers and experimental markers #90

Closed pariterre closed 1 year ago

pariterre commented 1 year ago

This change is Reviewable

codecov[bot] commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (b24a5e7) 0.00% compared to head (67ca649) 0.00%.

:exclamation: Current head 67ca649 differs from pull request most recent head c596f37. Consider uploading reports for the commit c596f37 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #90 +/- ## ====================================== Coverage 0.00% 0.00% ====================================== Files 10 10 Lines 2625 2698 +73 ====================================== - Misses 2625 2698 +73 ``` | [Impacted Files](https://codecov.io/gh/pyomeca/bioviz/pull/90?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pyomeca) | Coverage Δ | | |---|---|---| | [bioviz/\_\_init\_\_.py](https://codecov.io/gh/pyomeca/bioviz/pull/90?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pyomeca#diff-Ymlvdml6L19faW5pdF9fLnB5) | `0.00% <0.00%> (ø)` | | | [bioviz/biorbd\_vtk.py](https://codecov.io/gh/pyomeca/bioviz/pull/90?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pyomeca#diff-Ymlvdml6L2Jpb3JiZF92dGsucHk=) | `0.00% <0.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pyomeca). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pyomeca)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

pariterre commented 1 year ago

This PR also fixed the crazy slow bug (#87)

Ipuch commented 1 year ago

Shouldn't we have a test to verify that object or not created multiple times ? :)

pariterre commented 1 year ago

That is impossible to test properly, not without a long and painful process at least...